Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130062 / 24.10 / Removes unused fileds in apps #10423

Merged
merged 2 commits into from
Aug 11, 2024
Merged

NAS-130062 / 24.10 / Removes unused fileds in apps #10423

merged 2 commits into from
Aug 11, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Aug 9, 2024

Testing:
Code review.

Downstream

Affects Reasoning
Documentation Some unused fields removed from UI.

@undsoft undsoft requested a review from a team as a code owner August 9, 2024 15:22
@undsoft undsoft requested review from bvasilenko and removed request for a team August 9, 2024 15:22
@bugclerk bugclerk changed the title NAS-130062: Removes unused fileds in apps NAS-130062 / 24.10 / Removes unused fileds in apps Aug 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (b0c283c) to head (b4a57af).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10423   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files        1622     1622           
  Lines       55120    55120           
  Branches     6471     6471           
=======================================
  Hits        42391    42391           
  Misses      12729    12729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft requested a review from RehanY147 August 10, 2024 08:13
@undsoft undsoft merged commit cb348dd into master Aug 11, 2024
9 checks passed
@undsoft undsoft deleted the NAS-130062 branch August 11, 2024 07:33
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants