Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130369 / 24.10 / Clarify how to add translations #10387

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Aug 1, 2024

Changes:

Trying to make it easier for contributors to understand how to work with our translation system.

Testing:

Review only.

@undsoft undsoft requested a review from a team as a code owner August 1, 2024 11:00
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team August 1, 2024 11:00
@bugclerk
Copy link
Contributor

bugclerk commented Aug 1, 2024

@bugclerk bugclerk changed the title NAS-130369: Clarify how to add translations NAS-130369 / 24.10 / Clarify how to add translations Aug 1, 2024
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it's more clear for contributors to understand how to work with our translation system.

👍

@undsoft undsoft enabled auto-merge (squash) August 1, 2024 11:44
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.05%. Comparing base (157ed38) to head (5276da7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10387   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files        1597     1597           
  Lines       54911    54914    +3     
  Branches     6480     6480           
=======================================
+ Hits        42312    42315    +3     
  Misses      12599    12599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit d9815f0 into master Aug 1, 2024
9 checks passed
@undsoft undsoft deleted the NAS-130369 branch August 1, 2024 13:02
@bugclerk
Copy link
Contributor

bugclerk commented Aug 1, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants