Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130067 / 24.10 / Introduce OrNotAvailable pipe #10321

Merged
merged 3 commits into from
Jul 19, 2024
Merged

NAS-130067 / 24.10 / Introduce OrNotAvailable pipe #10321

merged 3 commits into from
Jul 19, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jul 17, 2024

And additional control flow syntax migration.

Testing: code review should be sufficient.

@undsoft undsoft requested a review from a team as a code owner July 17, 2024 10:39
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team July 17, 2024 10:39
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-130067: Introduce OrNotAvailable pipe NAS-130067 / 24.10 / Introduce OrNotAvailable pipe Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.75%. Comparing base (f5c9e7d) to head (c5e141f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10321      +/-   ##
==========================================
- Coverage   76.77%   76.75%   -0.02%     
==========================================
  Files        1595     1598       +3     
  Lines       54915    54956      +41     
  Branches     6487     6488       +1     
==========================================
+ Hits        42160    42183      +23     
- Misses      12755    12773      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good 👍

@undsoft undsoft merged commit f7fa55c into master Jul 19, 2024
10 checks passed
@undsoft undsoft deleted the NAS-130067 branch July 19, 2024 13:49
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants