Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129885 / 24.10 / Add customer designed login banner #10311

Merged
merged 9 commits into from
Jul 24, 2024

NAS-129885: Add customer designed login banner

62edca0
Select commit
Loading
Failed to load commit list.
Merged

NAS-129885 / 24.10 / Add customer designed login banner #10311

NAS-129885: Add customer designed login banner
62edca0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 23, 2024 in 0s

76.71% (-0.05%) compared to 27efed9

View this Pull Request on Codecov

76.71% (-0.05%) compared to 27efed9

Details

Codecov Report

Attention: Patch coverage is 79.51807% with 17 lines in your changes missing coverage. Please review.

Project coverage is 76.71%. Comparing base (27efed9) to head (62edca0).
Report is 11 commits behind head on master.

Files Patch % Lines
...vanced/access/access-form/access-form.component.ts 86.11% 5 Missing ⚠️
src/app/enums/system-state.enum.ts 0.00% 4 Missing ⚠️
...full-screen-dialog/full-screen-dialog.component.ts 0.00% 3 Missing ⚠️
src/app/views/sessions/signin/signin.component.ts 84.61% 2 Missing ⚠️
...rc/app/views/sessions/signin/store/signin.store.ts 84.61% 2 Missing ⚠️
src/app/modules/dialog/dialog.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10311      +/-   ##
==========================================
- Coverage   76.76%   76.71%   -0.05%     
==========================================
  Files        1597     1602       +5     
  Lines       54950    55097     +147     
  Branches     6487     6500      +13     
==========================================
+ Hits        42180    42268      +88     
- Misses      12770    12829      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov