NAS-128858 / 24.10 / Fix & improve http error handler

[bvasilenko]

Summary

This PR contains 2 changes:

1. The error modal window depicted in the ticket (Error(0)) was shown due to the fact that the handler received not an HTTP error, but a Job error from the websocket. I've fixed this handler.

2. Adjust HTTP error handler to show error title and message from HTTP errors, which was preventing from determining the root cause of the issue

Testing

On any box, for example on http://10.220.16.103

1. When user clicks Data Protection > Cloud Sync Tasks > Green "Success" Pill

2. At the error modal window, user clicks Download Logs

   • Important: you will need to adjust the code to simulate downloading HTTP error, similar to one shown below

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128858

[undsoft]

Changes look reasonable, thanks.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.71%. Comparing base (2bcff3a) to head (e71765d).

Files	Patch %	Lines
src/app/services/error-handler.service.ts	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10300      +/-   ##
==========================================
+ Coverage   76.70%   76.71%   +0.01%     
==========================================
  Files        1594     1594              
  Lines       54835    54839       +4     
  Branches     6477     6479       +2     
==========================================
+ Hits        42059    42072      +13     
+ Misses      12776    12767       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.