Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-128951 / 24.10 / If you edit VM to use Custom CPU, then try to switch back to host passthrough it gives error #10296

Merged
merged 2 commits into from
Jul 9, 2024
Merged

NAS-128951 / 24.10 / If you edit VM to use Custom CPU, then try to switch back to host passthrough it gives error #10296

merged 2 commits into from
Jul 9, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

@AlexKarpov98 AlexKarpov98 self-assigned this Jul 8, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner July 8, 2024 08:59
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team July 8, 2024 08:59
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128951

@bugclerk bugclerk changed the title NAS-128951: If you edit VM to use Custom CPU, then try to switch back to host passthrough it gives error NAS-128951 / 24.10 / If you edit VM to use Custom CPU, then try to switch back to host passthrough it gives error Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (392f8b1) to head (8f81598).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #10296   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files        1587     1587           
  Lines       54718    54720    +2     
  Branches     6470     6471    +1     
=======================================
+ Hits        41900    41902    +2     
  Misses      12818    12818

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

denysbutenko
denysbutenko approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching CPU for a VM works well. LGTM

@AlexKarpov98 AlexKarpov98 merged commit cc26049 into master Jul 9, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128951 branch July 9, 2024 05:48
@bugclerk
Copy link
Contributor

bugclerk commented Jul 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denysbutenko denysbutenko denysbutenko approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @denysbutenko