Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129852 / 24.10 / Missing share icons #10295

Merged
merged 2 commits into from
Jul 8, 2024
Merged

NAS-129852 / 24.10 / Missing share icons #10295

merged 2 commits into from
Jul 8, 2024

Conversation

AlexKarpov98
Copy link
Contributor

No description provided.

@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner July 8, 2024 08:57
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team July 8, 2024 08:57
@AlexKarpov98 AlexKarpov98 self-assigned this Jul 8, 2024
@bugclerk bugclerk changed the title NAS-129852: Missing share icons NAS-129852 / 24.10 / Missing share icons Jul 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, icons are back.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) July 8, 2024 09:16
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (392f8b1) to head (6e3956f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10295   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files        1587     1587           
  Lines       54718    54718           
  Branches     6470     6470           
=======================================
  Hits        41900    41900           
  Misses      12818    12818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit ce378ce into master Jul 8, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-129852 branch July 8, 2024 09:34
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants