-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-129686 / 24.04.2 / Fix SMB ACL form (by bvasilenko) #10290
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/24.04.2 #10290 +/- ##
==================================================
Coverage ? 66.05%
==================================================
Files ? 1426
Lines ? 54657
Branches ? 6579
==================================================
Hits ? 36103
Misses ? 18554
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backported.
This PR has been merged and conversations have been locked. |
backport |
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Summary
when AD cache is empty (see ticket), when Group combobox does not contain any suitable values to choose from,
I've changed to code to add the ability to type in a custom value from keyboard . When user presses Save, every value is validated for being a valid existing entry in the Active Directory
Middleware returns special type of AD entry
BOTH
, and when AD cache is empty (see ticket) it's not possible to distinguish a user from a group.It was agreed that, it would be unreasonable to try to squeeze in last-second middleware update for 24.04.2.
So, in such cases, the WebUI code was updated to make an attempt of detecting the type, otherwise it treats an AD entry as
GROUP
.Testing
AD02\domain users
)and/or add a User entry by typing on the keyboard (for example type in
AD02\administrator
)Original PR: #10271
Jira URL: https://ixsystems.atlassian.net/browse/NAS-129686