Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129913 / 24.10 / Control flow syntax migration 1 #10286

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jul 4, 2024

Code review is enough.

@undsoft undsoft requested a review from a team as a code owner July 4, 2024 18:30
@undsoft undsoft requested review from bvasilenko and removed request for a team July 4, 2024 18:30
@bugclerk bugclerk changed the title NAS-129913: Control flow syntax migration 1 NAS-129913 / 24.10 / Control flow syntax migration 1 Jul 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 4, 2024

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New syntax looks good!

@undsoft undsoft enabled auto-merge (squash) July 5, 2024 07:48
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (e59fc87) to head (a959e15).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10286      +/-   ##
==========================================
- Coverage   76.60%   76.59%   -0.01%     
==========================================
  Files        1578     1580       +2     
  Lines       54437    54476      +39     
  Branches     6439     6446       +7     
==========================================
+ Hits        41701    41727      +26     
- Misses      12736    12749      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 197f069 into master Jul 5, 2024
10 checks passed
@undsoft undsoft deleted the NAS-129913 branch July 5, 2024 08:14
@bugclerk
Copy link
Contributor

bugclerk commented Jul 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants