Skip to content

Commit

Permalink
NAS-131014: Update dedup warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
undsoft committed Sep 9, 2024
1 parent 458218b commit 6835a2a
Show file tree
Hide file tree
Showing 92 changed files with 122 additions and 21 deletions.
2 changes: 2 additions & 0 deletions src/app/helptext/storage/volumes/datasets/dataset-form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export const helptextDatasetForm = {
Our testing has shown that SHA512 performs better for such datasets.
We've changed the checksum value from SHA256 to SHA512. You can change it back in "Advanced Options".`),

deduplicationChecksumInlineWarning: T('For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.'),

dataset_form_readonly_tooltip: T('Set to prevent the dataset from being modified.'),

dataset_form_exec_tooltip: T('Set whether processes can be executed from within this dataset.'),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
[label]="'Checksum' | translate"
></ix-select>

@if (hasChecksumWarning) {
<ix-warning [message]="helptext.deduplicationChecksumInlineWarning"></ix-warning>
}

<ix-select
formControlName="readonly"
[label]="'Read-only' | translate"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ export class OtherOptionsSectionComponent implements OnInit, OnChanges {
private datasetFormService: DatasetFormService,
) {}

get hasChecksumWarning(): boolean {
return this.form.value.checksum === DatasetChecksum.Sha256
&& this.form.value.deduplication !== DeduplicationSetting.Off;
}

ngOnChanges(changes: IxSimpleChanges<this>): void {
if (changes.datasetPreset?.currentValue) {
this.setUpDatasetPresetSelect();
Expand Down
2 changes: 2 additions & 0 deletions src/app/pages/datasets/datasets.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
IxModalHeaderComponent,
} from 'app/modules/forms/ix-forms/components/ix-slide-in/components/ix-modal-header/ix-modal-header.component';
import { IxTextareaComponent } from 'app/modules/forms/ix-forms/components/ix-textarea/ix-textarea.component';
import { IxWarningComponent } from 'app/modules/forms/ix-forms/components/ix-warning/ix-warning.component';
import { SearchInput1Component } from 'app/modules/forms/search-input1/search-input1.component';
import { IxIconModule } from 'app/modules/ix-icon/ix-icon.module';
import { IxTableModule } from 'app/modules/ix-table/ix-table.module';
Expand Down Expand Up @@ -106,6 +107,7 @@ import { DatasetNodeComponent } from './components/dataset-node/dataset-node.com
IxChipsComponent,
IxTextareaComponent,
PageHeaderModule,
IxWarningComponent,
],
declarations: [
DatasetsManagementComponent,
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/af.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/ar.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/ast.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/az.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/be.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/bg.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/bn.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/br.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/bs.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/ca.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -1694,6 +1694,7 @@
"Flash Identify Light": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force Clear": "",
"Force Delete": "",
"Force Delete?": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/cy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/da.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -1290,6 +1290,7 @@
"Follow Symlinks": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/dsb.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/el.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/en-au.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/en-gb.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/eo.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/es-ar.json
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,7 @@
"Flash Identify Light": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force deletion of dataset <i>{datasetName}</i>?": "",
"Force unmount": "",
"Force using <a href=\"https://docs.aws.amazon.com/general/latest/gr/signature-version-2.html\" target=\"_blank\">Signature Version 2</a> to sign API requests. Set this only if your AWS provider does not support default version 4 signatures.": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/es-co.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/es-mx.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/es-ni.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/es-ve.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -1710,6 +1710,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force Clear": "",
"Force Delete": "",
"Force Delete?": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/et.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/eu.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/fa.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,7 @@
"Follow symlinks and copy the items to which they link.": "",
"Following container images are available to update:\n": "",
"For example if you set this value to 5, system will renew certificates that expire in 5 days or less.": "",
"For performance reasons SHA512 is recommended over SHA256 for datasets with deduplication enabled.": "",
"Force": "",
"Force Clear": "",
"Force Delete": "",
Expand Down
Loading

0 comments on commit 6835a2a

Please sign in to comment.