-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132340 / 25.04 / Move reporting exporters service to new api style #14898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Move reporting exporters service to new api style
NAS-132340 / 25.04 / Move reporting exporters service to new api style
Nov 7, 2024
Qubad786
force-pushed
the
mrehan/reporting-exporters-accepts-remove
branch
2 times, most recently
from
November 8, 2024 08:07
0ef9c75
to
78001fe
Compare
Qubad786
force-pushed
the
mrehan/reporting-exporters-accepts-remove
branch
from
November 8, 2024 08:58
78001fe
to
c335522
Compare
Qubad786
force-pushed
the
mrehan/reporting-exporters-accepts-remove
branch
2 times, most recently
from
November 10, 2024 09:24
6e085d6
to
a018066
Compare
yocalebo
reviewed
Nov 12, 2024
src/middlewared/middlewared/api/v25_04_0/reporting_exporters.py
Outdated
Show resolved
Hide resolved
src/middlewared/middlewared/api/v25_04_0/reporting_exporters.py
Outdated
Show resolved
Hide resolved
themylogin
reviewed
Nov 12, 2024
src/middlewared/middlewared/api/v25_04_0/reporting_exporters.py
Outdated
Show resolved
Hide resolved
Qubad786
force-pushed
the
mrehan/reporting-exporters-accepts-remove
branch
from
November 12, 2024 14:35
a018066
to
978fb4a
Compare
themylogin
reviewed
Nov 12, 2024
src/middlewared/middlewared/api/v25_04_0/reporting_exporters.py
Outdated
Show resolved
Hide resolved
Qubad786
force-pushed
the
mrehan/reporting-exporters-accepts-remove
branch
from
November 12, 2024 15:12
978fb4a
to
73f03c2
Compare
themylogin
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR converts reporting exporter service to new api style.