Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132340 / 25.04 / Move reporting exporters service to new api style #14898

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Qubad786
Copy link
Contributor

@Qubad786 Qubad786 commented Nov 7, 2024

Context

This PR converts reporting exporter service to new api style.

@bugclerk bugclerk changed the title Move reporting exporters service to new api style NAS-132340 / 25.04 / Move reporting exporters service to new api style Nov 7, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Nov 7, 2024

@Qubad786 Qubad786 force-pushed the mrehan/reporting-exporters-accepts-remove branch 2 times, most recently from 0ef9c75 to 78001fe Compare November 8, 2024 08:07
@Qubad786 Qubad786 added pending QA and removed WIP labels Nov 8, 2024
@Qubad786 Qubad786 requested a review from a team November 8, 2024 08:07
@Qubad786 Qubad786 force-pushed the mrehan/reporting-exporters-accepts-remove branch from 78001fe to c335522 Compare November 8, 2024 08:58
@Qubad786 Qubad786 force-pushed the mrehan/reporting-exporters-accepts-remove branch 2 times, most recently from 6e085d6 to a018066 Compare November 10, 2024 09:24
@Qubad786 Qubad786 requested review from a team and removed request for a team November 12, 2024 09:57
@Qubad786 Qubad786 force-pushed the mrehan/reporting-exporters-accepts-remove branch from a018066 to 978fb4a Compare November 12, 2024 14:35
@Qubad786 Qubad786 force-pushed the mrehan/reporting-exporters-accepts-remove branch from 978fb4a to 73f03c2 Compare November 12, 2024 15:12
Copy link
Contributor

@themylogin themylogin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Qubad786 Qubad786 merged commit 2f73b85 into master Nov 12, 2024
2 of 3 checks passed
@Qubad786 Qubad786 deleted the mrehan/reporting-exporters-accepts-remove branch November 12, 2024 15:36
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants