NAS-132072 / 25.04 / Add transfer setting to Truecloud Backup (by creatorcary)

[bugclerk]

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 51b7d9a82830cbfaf6fbf871a77b97788e400a9b
git cherry-pick -x 4907c38ecdb8788edba64c9b4eff262368a37139
git cherry-pick -x 2c533a0667afc494764b9dc1b4cf1a52decf5f41
git cherry-pick -x 48961daca8cb7b800054a1c3cf238a869644917c
git cherry-pick -x 7fac9b27717d8e00daea0294b058b72e99188c12
git cherry-pick -x d9dec1429c3dfd6996b06c5207c1f1413d89179d
git cherry-pick -x ad8c2dd0cc25dccda5332b2efa9690c3adc089ea

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 0394b0d1074d48d6d3d393d56c8379e17d7491c2

Replace the bwlimit and transfers fields of cloud_backup.create with a new transfer_setting enum field. The options right now are:

• DEFAULT
  • pack size given by $RESTIC_PACK_SIZE (default 16 MiB)
  • read concurrency given by $RESTIC_READ_CONCURRENCY (default 2 files)
• PERFORMANCE
  • pack size = 29 MiB
  • read concurrency given by $RESTIC_READ_CONCURRENCY (default 2 files)
• FAST_STORAGE
  • pack size = 58 MiB
  • read concurrency = 100 files

These are just the names I thought of; please weigh in on whether we should change the option names.

We also add a new public API endpoint cloud_backup.transfer_setting_choices which returns a list of the above options.

Warning

This must be merged at the same time as the required UI change.

Relevant documentation:
https://restic.readthedocs.io/en/latest/manual_rest.html
https://restic.readthedocs.io/en/latest/047_tuning_backup_parameters.html#

Original PR: #14867
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132072

[creatorcary]

Will add merge migration when ready to merge

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.