NAS-131141 / 25.04 / Shutdown/reboot audit #14546
Open
+119
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
reviewed
Sep 20, 2024
william-gr
reviewed
Sep 20, 2024
|
Just to make sure its not forgotten, it will need midcli changes too, right? |
yocalebo
reviewed
Sep 20, 2024
yocalebo
reviewed
Sep 20, 2024
|
themylogin
force-pushed
the
NAS-131141
branch
from
60a1bc5
to
19652ac
Compare
Co-authored-by: Caleb St. John <[email protected]>
yocalebo
reviewed
Sep 20, 2024
tests/api2/test_system_lifetime.py
Outdated
| except Exception: | ||
| pass | ||
| else: | ||
| if new_boot_id == boot_id: |
There was a problem hiding this comment.
How does this work? new_boot_id will never match the boot_id since the system will have been rebooted?
There was a problem hiding this comment.
Yes, this was a mistake. The test was not testing the fact that the system was indeed rebooted. Updated.
There was a problem hiding this comment.
yocalebo
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.