NAS-129059 / 25.04 / hide dimm2 and dimm3 temps on x10 #14545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
force-pushed
the
NAS-129059
branch
from
8c33f19
to
30bf85f
Compare
mgrimesix
reviewed
Sep 19, 2024
| if self.model == ControllerModels.X10.value and desc.startswith(('dimm2', 'dimm3')): | ||
| # x10 platform only has 2 DIMM slots (dimm0/1) populated so the others report | ||
| # -1C temperature but the descriptor status reports as "OK". | ||
| return True |
There was a problem hiding this comment.
The x10 can never and will never support the dimm2 and dimm3 slots?
Maybe don't report if the element status is 'UNSUPPORTED' | 'NOT_INSTALLED' | 'NOT_AVAILABLE'.
Or report only if element status is 'OK' | 'CRITICAL' | 'NONCRITICAL'.
Side notes: This is starting to look like an opportunity to use the match method. These platform specific things can be messy and ever growing.
There was a problem hiding this comment.
That's what I alluded to in my comment. The dimm module isn't populated but the descriptor still reports as "OK". So there isn't a concrete way of knowing that the module isn't populated. We basically have to make some form of assumption here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This platform has 4x dimm slots but only 2 are populated on X10. The dimms that are not populated report a status of "OK" but the temperature is reported as
-1C. This has been happening since CORE days. Fix it by not reporting those dimm sensors.