NAS-131143 / 25.04 / Always use python serializer and preserve types #14542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
privileges_group_mapping method that produces slig…privileges_group_mapping method that produces slig…
themylogin
force-pushed
the
NAS-131143
branch
from
4f10f64
to
d9d66ee
Compare
|
Won't this change the type for |
anodos325
reviewed
Sep 19, 2024
| @@ -1612,11 +1612,13 @@ async def group_extend(self, group, ctx): | |||
| group['name'] = group['group'] | |||
| group['users'] = ctx['memberships'].get(group['id'], []) | |||
|
|
|||
| privilege_mappings = privileges_group_mapping(ctx['privileges'], [group['gid']], 'local_groups') | |||
| privilege_mappings = await self.middleware.call( | |||
There was a problem hiding this comment.
I'd rather not add an extra middleware call per-group here especially when the op is so trivial. We can make the util version create a set instead and then convert to list for the user / group query output so that we're not changing things in the API response.
themylogin
force-pushed
the
NAS-131143
branch
from
d9d66ee
to
aa43efa
Compare
themylogin
changed the title
privileges_group_mapping method that produces slig…
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-131143 is targeted to the following versions which have not received their corresponding PRs: 24.10.0 |
|
This PR has been merged and conversations have been locked. |
|
time 4:00 |
|
Time tracking added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…htly different results