Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131172 / 25.04 / re-add REST audit logic to existing test_audit_rest file #14537

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

creatorcary
Copy link
Contributor

@creatorcary creatorcary commented Sep 18, 2024

We have removed the REST related tests that actually verify the audit logic is functioning properly. This PR adds those tests back in a single file for ease of removing them again when we remove the REST interface in one or more years from now.

Passing: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/799/

@creatorcary creatorcary requested a review from a team September 18, 2024 14:36
@bugclerk bugclerk changed the title re-add REST audit logic to existing test_audit_rest file NAS-131172 / 25.04 / re-add REST audit logic to existing test_audit_rest file Sep 18, 2024
@bugclerk
Copy link
Contributor

@creatorcary creatorcary merged commit c425368 into master Sep 18, 2024
2 of 3 checks passed
@creatorcary creatorcary deleted the NAS-131172 branch September 18, 2024 14:41
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants