NAS-131259 / 25.04 / Shift more expensive unit tests to tests/unit #14531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The odds of these features regressing in a PR are minimal and so we should move them to our unit tests that are run with incremental builds. This also fixes an issue where pam_fail_delay() could actually result in delays as small as 1.20 seconds, and so we need to not be quite so restrictive in testing.
bugclerk
changed the title
bmeagherix
approved these changes
Sep 17, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The odds of these features regressing in a PR are minimal and so we should move them to our unit tests that are run with incremental builds.
This also fixes an issue where pam_fail_delay() could actually result in delays as small as 1.20 seconds, and so we need to not be quite so restrictive in testing.