Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131208 / 25.04 / Improvements to mounting/umounting docker datasets #14525

Merged
merged 10 commits into from
Sep 18, 2024

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Sep 15, 2024

This PR adds changes to improve docker datasets mount/umount behavior. Earlier we used to mount/umount on docker service start/stop but that was excessive after discussion with Caleb and the finalized workflow was:

  1. Mount on system boot if docker is configured
  2. Umount/mount only if docker pool is changed

@sonicaj sonicaj self-assigned this Sep 15, 2024
@bugclerk bugclerk changed the title Improvements to mounting/umounting docker datasets NAS-131208 / 25.04 / Improvements to mounting/umounting docker datasets Sep 15, 2024
@bugclerk
Copy link
Contributor

@truenas truenas deleted a comment from bugclerk Sep 15, 2024
@sonicaj sonicaj added pending QA and removed WIP labels Sep 17, 2024
@sonicaj sonicaj requested a review from a team September 17, 2024 23:15
@sonicaj sonicaj merged commit e507208 into master Sep 18, 2024
3 checks passed
@sonicaj sonicaj deleted the mount-umount-docker-improvements branch September 18, 2024 21:19
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants