Skip to content

Commit

Permalink
Fix typo in READONLY role (#12455)
Browse files Browse the repository at this point in the history
Constants were renamed during review process, and the item granting
READONLY role ability to read file attributes was missed resulting
in READONLY being unable to read filesystem-related attributes.
  • Loading branch information
anodos325 authored Nov 6, 2023
1 parent d74f952 commit a579634
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/middlewared/middlewared/role.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class Role:
'FILESYSTEM_DATA_WRITE']),

'FULL_ADMIN': Role(full_admin=True),
'READONLY': Role(includes=['FILESYSTEM_READ_ATTRS']),
'READONLY': Role(includes=['FILESYSTEM_ATTRS_READ']),

'SHARING_ISCSI_EXTENT_READ': Role(),
'SHARING_ISCSI_EXTENT_WRITE': Role(includes=['SHARING_ISCSI_EXTENT_READ']),
Expand Down

0 comments on commit a579634

Please sign in to comment.