Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133725 / None / scsi: mpi3mr: restrict scsih IOCTLs for NVMe #206

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ixhamza
Copy link
Contributor

@ixhamza ixhamza commented Jan 23, 2025

Confirmed that it fixes Identify error. NVMe status -1 for https://ixsystems.atlassian.net/browse/NAS-133725 but need to sanity test it with tri-mode NVMe as well.

@ixhamza ixhamza requested a review from amotin January 23, 2025 22:37
@bugclerk bugclerk changed the title scsi: mpi3mr: restrict scsih IOCTLs for NVMe NAS-133725 / None / scsi: mpi3mr: restrict scsih IOCTLs for NVMe Jan 23, 2025
Copy link
Collaborator

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, except I am not sure ENXIO is the best error code here. What error do you see if you call these IOCTLs on some other HBA?

@ixhamza ixhamza requested a review from usaleem-ix January 24, 2025 10:42
@ixhamza
Copy link
Contributor Author

ixhamza commented Jan 24, 2025

@amotin, agreed! I couldn’t find the HBA implementing the SCSI host ioctl. However, in cases where it’s unimplemented, kernel returns EINVAL. I've updated accordingly!

@ixhamza
Copy link
Contributor Author

ixhamza commented Jan 24, 2025

Sanity tested with tri-mode NVMe as well on http://m60.mav.ixsystems.net/.

@ixhamza ixhamza merged commit cce2e7b into truenas/linux-6.12 Jan 24, 2025
6 checks passed
@bugclerk
Copy link

Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133725 target versions as no JIRA version corresponds to this PR

@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 24, 2025
@ixhamza ixhamza deleted the NAS-133725 branch January 24, 2025 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants