Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-122619 / 24.04/ fs/cifs - add ZFS ACL support to SMB client #144

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

anodos325
Copy link
Contributor

Add an xattr handler with same namespace as ZFS ACL xattr handler to allow userspace utilities to easily preserve and convert contents of SMB Security Descriptor DACL into native ZFS ACL when ingesting data during migration via SMB client (for example using rsync with the explicit option to preserve the xattr in question).

This PR also adds a new procfs endpoint:
/proc/fs/cifs/zfsacl_configuration_options that can be used to control error handling for cases where we can't convert SID into a Unix ID, and currently also whether we allow setting NT ACL via xattr writes on remote SMB server (disabled by default).

Add an xattr handler with same namespace as ZFS ACL xattr handler
to allow userspace utilities to easily preserve and convert
contents of SMB Security Descriptor DACL into native ZFS ACL
when ingesting data during migration via SMB client (for example
using rsync with the explicit option to preserve the xattr in
question).

This PR also adds a new procfs endpoint:
/proc/fs/cifs/zfsacl_configuration_options that can be used to
control error handling for cases where we can't convert SID
into a Unix ID, and currently also whether we allow setting
NT ACL via xattr writes on remote SMB server (disabled by default).
@bugclerk bugclerk changed the title fs/cifs - add ZFS ACL support to SMB client NAS-122619 / None / fs/cifs - add ZFS ACL support to SMB client Dec 21, 2023
@bugclerk
Copy link

@anodos325 anodos325 changed the title NAS-122619 / None / fs/cifs - add ZFS ACL support to SMB client NAS-122619 / 24.04/ fs/cifs - add ZFS ACL support to SMB client Dec 21, 2023
@anodos325
Copy link
Contributor Author

Rebase of PR #110

@anodos325 anodos325 requested a review from bmeagherix December 21, 2023 13:37
fs/smb/client/cifsacl.c Show resolved Hide resolved
fs/smb/client/cifsacl.c Outdated Show resolved Hide resolved
fs/smb/client/cifs_debug.c Outdated Show resolved Hide resolved
fs/smb/client/cifs_debug.c Outdated Show resolved Hide resolved
* Change buffer size and error.
@anodos325 anodos325 merged commit dcdf58f into truenas/linux-6.6 Dec 29, 2023
6 checks passed
@anodos325 anodos325 deleted the NAS-122619_kernel_6.6 branch December 29, 2023 16:03
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants