Merge pull request #12 from truefoundry/nap-oauth-add

Added NAP and oauth fixes for GKE
truefoundry · Mar 12, 2024 · ba4edf7 · ba4edf7
2 parents 2856743 + f306e85
commit ba4edf7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/gke.tf b/gke.tf
@@ -21,53 +21,53 @@ resource "google_container_cluster" "cluster" {
     enabled = true
     resource_limits {
       maximum       = var.cluster_nap_node_config.max_cpu
-      minimum       = 2
+      minimum       = 0
       resource_type = "cpu"
     }
     resource_limits {
       maximum       = var.cluster_nap_node_config.max_memory
-      minimum       = 4
+      minimum       = 0
       resource_type = "memory"
     }
     resource_limits {
-      maximum       = 4
+      maximum       = 256
       minimum       = 0
       resource_type = "nvidia-tesla-k80"
     }
     resource_limits {
       resource_type = "nvidia-tesla-p100"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     resource_limits {
       resource_type = "nvidia-tesla-p4"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     resource_limits {
       resource_type = "nvidia-tesla-v100"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     resource_limits {
       resource_type = "nvidia-tesla-t4"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     resource_limits {
       resource_type = "nvidia-tesla-a100"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     resource_limits {
       resource_type = "nvidia-a100-80gb"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     resource_limits {
       resource_type = "nvidia-l4"
       minimum       = 0
-      maximum       = 4
+      maximum       = 256
     }
     auto_provisioning_defaults {
       service_account = "default"

diff --git a/variables.tf b/variables.tf
@@ -50,7 +50,7 @@ variable "cluster_nap_node_config" {
     enable_integrity_monitoring = optional(bool, true)
     autoscaling_profile         = optional(string, "OPTIMIZE_UTILIZATION")
     max_cpu                     = optional(number, 1024)
-    max_memory                  = optional(number, 1024)
+    max_memory                  = optional(number, 8172)
     auto_repair                 = optional(bool, true)
     auto_upgrade                = optional(bool, true)
     max_surge                   = optional(number, 1)
@@ -74,7 +74,10 @@ variable "oauth_scopes" {
     "https://www.googleapis.com/auth/cloud-platform",
     "https://www.googleapis.com/auth/devstorage.read_only",
     "https://www.googleapis.com/auth/logging.write",
-    "https://www.googleapis.com/auth/monitoring.write",
+    "https://www.googleapis.com/auth/monitoring",
+    "https://www.googleapis.com/auth/service.management.readonly",
+    "https://www.googleapis.com/auth/servicecontrol",
+    "https://www.googleapis.com/auth/trace.append"
   ]
 }