Port pydantic v1 models to pydantic v2 #224

abhinavk454 · 2024-06-17T17:22:02Z

Closes #219

TODO:

Change fields which start with model_*, especially model_config - this may or may not be a breaking change
Verify if prisma store is still able to function correctly

backend/settings.py

backend/server/decorators.py

chiragjn · 2024-06-24T14:36:59Z

Apologies for the delay here, we had some improvements planned which took higher priority.
I'll pick this up now and resolve the conflicts

…ting

…config

backend/modules/metadata_store/base.py

backend/database/schema.prisma

S1LV3RJ1NX

Answered few of your questions.

…hinavk454-pydantic_v2

backend/types.py

backend/modules/metadata_store/prismastore.py

* Port pydantic v1 models to pydantic v2 * fad * Port pydantic v1 models to pydantic v2 * Port pydantic v1 models to pydantic v2 * update default values, type annotations, validators * Fixes on top of merging main * More typing refactor for consistency * Add todo for fields to fix * Add exception if pydantic v2 sends us obj instead of dict when validating * Fix regex type constraint and rename model_config to embedding_model_config * Refactor primsa store to work with pydantic v2 * resolved conflicts * Fixed pydantic * Removed model_serializer, replaced with model_dump, added enum_values * Fix enum values config and separate model type and module type * Fix frontend types to match up with backend types --------- Co-authored-by: Chirag Jain <[email protected]> Co-authored-by: Prathamesh <[email protected]>

abhinavk454 added 4 commits June 17, 2024 09:41

Port pydantic v1 models to pydantic v2

1ad8faa

fad

d2398a5

Port pydantic v1 models to pydantic v2

23b6924

Port pydantic v1 models to pydantic v2

d7af983

chiragjn requested review from S1LV3RJ1NX and chiragjn June 18, 2024 14:24

chiragjn reviewed Jun 19, 2024

View reviewed changes

backend/settings.py Outdated Show resolved Hide resolved

chiragjn reviewed Jun 19, 2024

View reviewed changes

backend/settings.py Outdated Show resolved Hide resolved

chiragjn reviewed Jun 19, 2024

View reviewed changes

backend/server/decorators.py Outdated Show resolved Hide resolved

chiragjn added 2 commits June 25, 2024 03:30

Pull main and fix conflicts

aaa91f6

update default values, type annotations, validators

5c2406c

chiragjn changed the title ~~Port pydantic v1 models to pydantic v2~~ [WIP] Port pydantic v1 models to pydantic v2 Jun 24, 2024

chiragjn marked this pull request as draft June 24, 2024 22:57

chiragjn added 4 commits July 31, 2024 02:24

Merge with origin/main and fix conflicts

622ffc0

Fixes on top of merging main

563b20a

More typing refactor for consistency

094ea4f

Add todo for fields to fix

b870dd6

chiragjn force-pushed the pydantic_v2 branch from c2d73a9 to b870dd6 Compare July 30, 2024 21:43

chiragjn added 3 commits July 31, 2024 03:31

Add exception if pydantic v2 sends us obj instead of dict when valida…

1f5d0b7

…ting

Fix regex type constraint and rename model_config to embedding_model_…

02269c9

…config

Refactor primsa store to work with pydantic v2

c7b5328

chiragjn changed the title ~~[WIP] Port pydantic v1 models to pydantic v2~~ Port pydantic v1 models to pydantic v2 Jul 31, 2024

chiragjn marked this pull request as ready for review July 31, 2024 12:07