Skip to content

Commit

Permalink
chore(qbittorrent) update env variables for qbittorrent (#29618)
Browse files Browse the repository at this point in the history
**Description**
oneDr0p removed the python code that allowed variables to set ini
options.... onedr0p/containers#1109
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
manual editing the conf doesnt seem to work as it resets after a restart
too.

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning
- [ ] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
  • Loading branch information
xstar97 authored Nov 20, 2024
1 parent 2838f45 commit b6c4506
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/stable/qbittorrent/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ sources:
- https://github.com/truecharts/charts/tree/master/charts/stable/qbittorrent
- https://hub.docker.com/r/mjmeli/qbittorrent-port-forward-gluetun-server
type: application
version: 22.1.7
version: 22.1.8
12 changes: 8 additions & 4 deletions charts/stable/qbittorrent/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,19 @@ workload:
containers:
main:
env:
QBT_WEBUI_PORT: "{{ .Values.service.main.ports.main.port }}"
QBT_TORRENTING_PORT: "{{ .Values.service.torrent.ports.torrent.port }}"

# deprecated https://github.com/onedr0p/containers/pull/1109
# set the default port
QBITTORRENT__PORT: "{{ .Values.service.main.ports.main.port }}"
# QBITTORRENT__PORT: "{{ .Values.service.main.ports.main.port }}"
# stops users from bricking their chart from setting the ip to a random ip when its a container.
QBT_Preferences__WebUI__Address: "*"
# QBT_Preferences__WebUI__Address: "*"
# set port from gui.
QBT_BitTorrent__Session__Port: "{{ .Values.service.torrent.ports.torrent.port }}"
# QBT_BitTorrent__Session__Port: "{{ .Values.service.torrent.ports.torrent.port }}"
# legacy ini key
# key deprecated https://github.com/qbittorrent/qBittorrent/issues/8324
QBT_Preferences__Connection__PortRangeMin: "{{ .Values.service.torrent.ports.torrent.port }}"
# QBT_Preferences__Connection__PortRangeMin: "{{ .Values.service.torrent.ports.torrent.port }}"
qbitportforward:
enabled: true
type: CronJob
Expand Down

0 comments on commit b6c4506

Please sign in to comment.