Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

fix: fastify ERR_HTTP_HEADERS_SENT is reply is not awaited #428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/adapters/node-http/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const createOpenApiNodeHttpHandler = <
res.setHeader(key, value);
}
}
res.end(JSON.stringify(body));
return res.end(JSON.stringify(body));
};

const method = req.method! as OpenApiMethod & 'HEAD';
Expand All @@ -91,8 +91,7 @@ export const createOpenApiNodeHttpHandler = <

// Can be used for warmup
if (method === 'HEAD') {
sendResponse(204, {}, undefined);
return;
return sendResponse(204, {}, undefined);
}

throw new TRPCError({
Expand Down Expand Up @@ -144,7 +143,7 @@ export const createOpenApiNodeHttpHandler = <
const statusCode = meta?.status ?? 200;
const headers = meta?.headers ?? {};
const body: OpenApiSuccessResponse<typeof data> = data;
sendResponse(statusCode, headers, body);
return sendResponse(statusCode, headers, body);
} catch (cause) {
const error = getErrorFromUnknown(cause);

Expand Down Expand Up @@ -187,7 +186,7 @@ export const createOpenApiNodeHttpHandler = <
code: error.code,
issues: isInputValidationError ? (error.cause as ZodError).errors : undefined,
};
sendResponse(statusCode, headers, body);
return sendResponse(statusCode, headers, body);
}
};
};