Use List/ListItem components from mui #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I'll take a closer look at this soon! |
| @@ -4,8 +4,19 @@ import React from 'react'; | |||
| import ListItem from './ListItem'; | |||
| import ReactCSSTransitionGroup from './TimeoutTransitionGroup'; | |||
| import { mergeAndPrefix } from '../utils/stylePropable'; | |||
| import { List } from 'material-ui'; | |||
There was a problem hiding this comment.
import List from 'material-ui/lib/lists/list';
|
We still need to figure out why |
|
Another issue I forgot to mention is the ListItem on click ripple color needs to be tweaked. |
|
Good point 👍 , I have made the changes. |
|
Hey @troutowicz, did you have time to take a look at the I will probably investigate further next week. |
|
I have not, my schedule has been and will be packed through mid this week. Let me know what your investigations turn up. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use List/ListItem components from mui.
We have to use my fork of material-ui but as soon as they have fixed the issue with the utils/extends, we will switch again ;).
Fix #18