fix(sonar): Generic wildcard types should not be used in return types…

… java:S1452
tronprotocol · Jun 17, 2024 · c2bf297 · c2bf297
1 parent b2898ae
commit c2bf297
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/framework/src/main/java/org/tron/common/application/AbstractService.java b/framework/src/main/java/org/tron/common/application/AbstractService.java
@@ -18,12 +18,12 @@ public abstract class AbstractService implements Service {
 
 
   @Override
-  public CompletableFuture<?> start() {
+  public CompletableFuture<Boolean> start() {
     logger.info("{} starting on {}", name, port);
-    final CompletableFuture<?> resultFuture = new CompletableFuture<>();
+    final CompletableFuture<Boolean> resultFuture = new CompletableFuture<>();
     try {
       innerStart();
-      resultFuture.complete(null);
+      resultFuture.complete(true);
       logger.info("{} started, listening on {}", name, port);
     } catch (Exception e) {
       resultFuture.completeExceptionally(e);
@@ -32,12 +32,12 @@ public CompletableFuture<?> start() {
   }
 
   @Override
-  public CompletableFuture<?> stop() {
+  public CompletableFuture<Boolean> stop() {
     logger.info("{} shutdown...", name);
-    final CompletableFuture<?> resultFuture = new CompletableFuture<>();
+    final CompletableFuture<Boolean> resultFuture = new CompletableFuture<>();
     try {
       innerStop();
-      resultFuture.complete(null);
+      resultFuture.complete(true);
       logger.info("{} shutdown complete", name);
     } catch (Exception e) {
       resultFuture.completeExceptionally(e);

diff --git a/framework/src/main/java/org/tron/common/application/HttpService.java b/framework/src/main/java/org/tron/common/application/HttpService.java
@@ -44,7 +44,7 @@ public void innerStop() throws Exception {
   }
 
   @Override
-  public CompletableFuture<?> start() {
+  public CompletableFuture<Boolean> start() {
     initServer();
     ServletContextHandler context = initContextHandler();
     addServlet(context);

diff --git a/framework/src/main/java/org/tron/common/application/RpcService.java b/framework/src/main/java/org/tron/common/application/RpcService.java
@@ -59,7 +59,7 @@ public void innerStop() throws Exception {
   }
 
   @Override
-  public CompletableFuture<?> start() {
+  public CompletableFuture<Boolean> start() {
     NettyServerBuilder serverBuilder = initServerBuilder();
     addService(serverBuilder);
     addInterceptor(serverBuilder);

diff --git a/framework/src/main/java/org/tron/common/application/Service.java b/framework/src/main/java/org/tron/common/application/Service.java
@@ -24,14 +24,14 @@ public interface Service {
    *
    * @return completion state
    */
-  CompletableFuture<?> start();
+  CompletableFuture<Boolean> start();
 
   /**
    * Stops the service and performs needed cleanup.
    *
    * @return completion state
    */
-  CompletableFuture<?> stop();
+  CompletableFuture<Boolean> stop();
 
   boolean isEnable();