Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVREL-128 Cover missing gateways #72

Merged
merged 6 commits into from
Jul 21, 2023
Merged

DEVREL-128 Cover missing gateways #72

merged 6 commits into from
Jul 21, 2023

Conversation

zero-bites
Copy link
Collaborator

@zero-bites zero-bites commented Jul 18, 2023 •
edited
Loading

Fixes

Adds testing coverage for:

  • BalanceGateway
  • OfflinePaymentGateway
  • PaymentGateway

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, create a GitHub Issue in this repository.

@zero-bites zero-bites marked this pull request as ready for review July 18, 2023 04:37
@Aman-Aalam Aman-Aalam changed the base branch from master to dev July 19, 2023 03:20
@zero-bites zero-bites merged commit e4006f9 into dev Jul 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aman-Aalam Aman-Aalam Aman-Aalam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zero-bites @Aman-Aalam