School history #1173
Open
School history #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodo42
commented
Jun 27, 2018
| {{ field.errors }} | ||
| {% if field.name == "school" %} | ||
| <span class="col-md-7"> | ||
| {{ field | bootstrap_inline}} |
There was a problem hiding this comment.
Tu by sa zišlo mať autocomplete. Hral som sa s tým asi hodinu, skúšal som podobné veci ako je v registrácii, ale nepodarilo sa mi to. Viete mi poradiť? Podobne by sa aj na dátum zišiel kalendár ako pri registrácii.
mhozza
requested changes
Jul 1, 2018
mhozza
reviewed
Jul 1, 2018
| @@ -111,7 +111,7 @@ def get_submit_queryset(self, res_request): | |||
| ).distinct( | |||
| 'user', 'task', 'submit_type' | |||
| ).select_related( | |||
| 'user', 'user__school', 'task' | |||
There was a problem hiding this comment.
Tieto select related sluzia na optimalizaciu, treba ich nahradit nejakou alternativou.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1092
Obsahuje dátovú migráciu, ktorá premigruje školy z modelu
UserdoUserSchool. Pozrite, či behá v pohde. Ja si ju tiež ešte otestujem.Naprieč kódom som na mnohých miestach odstránil školu zo
select_relatedaprefetch_related. Poupravoval som exporty dát, tvorbu userov v testoch.V zoznamoch účastníkov a výsledkovkách sa už zobrazuje škola v danom čase.