Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections Page Rough Design #85

Merged
merged 23 commits into from
Nov 8, 2023

Conversation

Tyler-Lentz
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz commented Oct 16, 2023

first part of #86

This PR includes the basic design layout of the connections page with some mock values for display purposes.

Make sure to run the application through docker and not the local react dev server because that is how it will be run during test flights and competition.

Changes:

  1. basic design layout of the connection page and its 3 subpages.
  2. slightly modified the linter config to allow you to use unused variables if they are prefixed with an underscore
  3. removed the /camera route as its functionality will be completely covered by the obc connection page
  4. new npm packages:
    • react-modal for modal dialogue boxes
    • react-image-gallery for a nice image gallery
    • react-leaflet for maps
    • react-tooltip for hover tool tips. (Didn't end up using this, but probably will in the future so I didn't bother removing it.)
  5. TuasMap wrapper class around Leaflet. This lets us keep the same look of map throughout all of our maps without having to copy code. To insert extra functionality into the map you can insert custom components as children to the TuasMap. See the Input page's PR for an example of this if you are curious (e.g. the <MapIllustrator /> and <MapClickHandler /> components)

Three kinds of feedbacks would be greatly apprecated:

  1. Run in your web browser with your screen size and see if anything seems weird.
  2. Any unclear / uncommented code that you think should have an explanation.
  3. Anything you think might make sense to do/structure differently

@Tyler-Lentz Tyler-Lentz self-assigned this Oct 17, 2023
@Tyler-Lentz Tyler-Lentz added the feature New feature or request label Oct 17, 2023
@Tyler-Lentz Tyler-Lentz changed the title Add the Connections Page Connections Page Rough Design Nov 3, 2023
@Tyler-Lentz Tyler-Lentz marked this pull request as ready for review November 3, 2023 23:47
Copy link
Member

@atar13 atar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. UI scales well on all the connection pages regardless of the window size.

Love the terminal on the antenna tracker page and the full screen on the image viewer is a great idea.

Mainly had two issues I ran into:

  • The back button doesn't work on the radiomavlink page once you're logged into influxdb. It seems like the iframe is handling the back button events. This isn't the biggest deal in the world since you can just hit the connections tab on the navbar.
  • The background color changing color animations don't work on Firefox (where the background changes to red/green when you hover over each connection). Works fine on Chromium and Webkit.

@atar13
Copy link
Member

atar13 commented Nov 8, 2023

Also my influxdb container was crashing until I updated it to v2.7 in the docker compose. Not sure if anyone else is running into this issue or if it's just me.

@Tyler-Lentz
Copy link
Contributor Author

Looks very good. UI scales well on all the connection pages regardless of the window size.

Love the terminal on the antenna tracker page and the full screen on the image viewer is a great idea.

Mainly had two issues I ran into:

  • The back button doesn't work on the radiomavlink page once you're logged into influxdb. It seems like the iframe is handling the back button events. This isn't the biggest deal in the world since you can just hit the connections tab on the navbar.
  • The background color changing color animations don't work on Firefox (where the background changes to red/green when you hover over each connection). Works fine on Chromium and Webkit.

For future reference,

  1. Not sure if it's easy to mess with iframes this way, so just going to leave it since the navbar should work okay.
  2. Firefox seems to just not support the has selector currently, which seems like it is the problem. Hopefully future versions of firefox will support it. (As of 119 it does not)

@Tyler-Lentz Tyler-Lentz merged commit 6233dad into refactor/frontend Nov 8, 2023
8 checks passed
@Tyler-Lentz Tyler-Lentz deleted the feat/connection-page-design branch November 8, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants