-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connections Page Rough Design #85
Conversation
…to connection subpages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. UI scales well on all the connection pages regardless of the window size.
Love the terminal on the antenna tracker page and the full screen on the image viewer is a great idea.
Mainly had two issues I ran into:
- The back button doesn't work on the radiomavlink page once you're logged into influxdb. It seems like the iframe is handling the back button events. This isn't the biggest deal in the world since you can just hit the connections tab on the navbar.
- The background color changing color animations don't work on Firefox (where the background changes to red/green when you hover over each connection). Works fine on Chromium and Webkit.
Also my influxdb container was crashing until I updated it to v2.7 in the docker compose. Not sure if anyone else is running into this issue or if it's just me. |
For future reference,
|
first part of #86
This PR includes the basic design layout of the connections page with some mock values for display purposes.
Make sure to run the application through docker and not the local react dev server because that is how it will be run during test flights and competition.
Changes:
/camera
route as its functionality will be completely covered by the obc connection pagereact-modal
for modal dialogue boxesreact-image-gallery
for a nice image galleryreact-leaflet
for mapsreact-tooltip
for hover tool tips. (Didn't end up using this, but probably will in the future so I didn't bother removing it.)<MapIllustrator />
and<MapClickHandler />
components)Three kinds of feedbacks would be greatly apprecated: