Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Fix predicates for device assert inside reduction/scan region #5033

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[Backend] Fix predicates for device assert inside reduction/scan region #5033

merged 1 commit into from
Nov 5, 2024

Commits on Nov 4, 2024

  1. [Backend] Fix predicates for device assert inside reduction/scan region 

    Reductions have special handling for side effectful "combine ops" (e.g. "add" for a sum reduction). In the presence of side effects, a predicate is computed to determine whether a thread should participate in the reduction, to ensure that invalid/uninitialized data is not operated on. See [] for more details.

Previously, the predicate logic was incorrect for 2D reductions. This PR fixes the logic and adds a python test.
    @davidberard98
    davidberard98 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1f3198c View commit details
    Browse the repository at this point in the history