Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND] Delete dead code of visit_FunctionDef's handling of default argument #4778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lijinpei
Copy link
Contributor

@lijinpei lijinpei commented Sep 21, 2024

  • The ir-builder's insertion point has not been set, so created op is not inserted into anywhere.
  • Map of argument to func-op entry-bb argument is inserted later into lscope/local_defs. Map them to default arg is meaningless.

The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.

Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because FILL THIS IN.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

argument

- The ir-builder's insertion point has not been set, so created op is
  not inserted into anywhere.
- Map of argument to func-op entry-bb argument is inserted later into
  `lscope/local_defs`. Map them to default arg is meaningless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant