Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off fast log #4777

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Turn off fast log #4777

merged 1 commit into from
Sep 21, 2024
+3 −2

Conversation

ThomasRaoux
Copy link
Collaborator

Temporarily turn off log for now to deal with precision problem.

@ThomasRaoux
Turn off fast log
e70f424 
Temporarily turn off log for now to deal with precision problem.
Jokeren
Jokeren approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@Jokeren Jokeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be that fast math has triggered quite a few problems. Is it possible to add test cases for these ops?

@ThomasRaoux ThomasRaoux merged commit 20f4b41 into triton-lang:main Sep 21, 2024
7 checks passed
@ThomasRaoux
Copy link
Collaborator Author

Seems to be that fast math has triggered quite a few problems. Is it possible to add test cases for these ops?

would not be trivial to extract :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jokeren Jokeren Jokeren approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasRaoux @Jokeren