[BACKEND] Switch back to use llvm.load for shared memory load #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we don't have predicates we can use llvm.load. Using inline asm for i8 types can cause inneficient code generation in llvm due to the interaction with DAG legalizer.
Jokeren
reviewed
Sep 21, 2024
| @@ -290,6 +290,13 @@ static std::string getConstraintForBitwidth(unsigned bitwidth) { | |||
| } | |||
| } | |||
|
|
|||
| static bool isTruePred(Value pred) { | |||
There was a problem hiding this comment.
How about isConstantTruePred?
Jokeren
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't have predicates we can use llvm.load. Using inline asm for i8 types can cause inefficient code generation in llvm due to the interaction with DAG legalizer.