Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clang-12 to fix issue with LLVM_ABI_BREAKING_CHECKS #4760

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Use clang-12 to fix issue with LLVM_ABI_BREAKING_CHECKS #4760

merged 2 commits into from
Oct 10, 2024

Commits on Oct 7, 2024

  1. Remove LLVM_ABI_BREAKING_CHECKS=FORCE_OFF. 

    The issue raised in triton-lang#4212 (comment) and temporary fixed in triton-lang#4512 has now been fixed upstream.

The non-deterministic seed inside the hashing function
(included in this llvm commit: llvm/llvm-project@ce80c80) was disabled for clang <= 11 for non-pic builds.

This was removed again in xgupta/llvm-project@5255b81 and we can enable ABI-breaking checks again.

We build LLVM with PIC. If anyone ever builds with non-PIC, they will get a compilation error and need to disable LLVM_ABI_BREAKING_CHECKS manually.
    @karupayun @chsigg
    karupayun authored and chsigg committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    78050f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Revert llvm-hash.txt

    @chsigg
    chsigg authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    81d5ec5 View commit details
    Browse the repository at this point in the history