Fix the unstable behavior of 'test_where_warning' #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retribution98
force-pushed
the
fix-test-where
branch
from
769e49c
to
a2d73b3
Compare
ThomasRaoux
reviewed
Sep 18, 2024
| @@ -341,7 +341,7 @@ def kernel(a=1, B: tl.constexpr = ""): | |||
| triton.compile(triton.compiler.ASTSource(fn=kernel, signature={'a': 'i32'}, constants={'B': ""})) | |||
|
|
|||
|
|
|||
| def test_where_warning(): | |||
| def test_where_warning(monkeypatch): | |||
There was a problem hiding this comment.
can we use the existing fresh_triton_cache
There was a problem hiding this comment.
Thank you so much! I didn't know about this option, but it's a great fit.
I have updated the PR.
An unexpected 'test_where_warning' failure occurred if the test was restarted. This happens because the compiler uses the cache and does not write a warning. The environment parameter 'TRITON_ALWAYS_COMPILE' is now used to skip the cache. Signed-off-by: Kirill Suvorov <[email protected]>
Retribution98
force-pushed
the
fix-test-where
branch
from
a2d73b3
to
a6cab24
Compare
ThomasRaoux
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unexpected 'test_where_warning' failure occurred if the test was restarted. This happens because the compiler uses the cache and does not write a warning. The environment parameter 'TRITON_ALWAYS_COMPILE' is now used to skip the cache.
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)