[AMD] Predicate tt.dot to override select in pipeline epilogue #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjw36
requested review from
antiagainst,
zhanglx13 and
ptillet
as code owners
ThomasRaoux
approved these changes
Sep 10, 2024
ThomasRaoux
reviewed
Sep 10, 2024
| @@ -543,6 +543,21 @@ createStreamOps(scf::ForOp &forOp, tt::CoarseSchedule &schedule, | |||
| return allocs; | |||
| } | |||
|
|
|||
| static Operation *streamPredication(RewriterBase &rewriter, Operation *op, | |||
| Value pred) { | |||
| // Predicate dot so select will be removed (reduces register pressure) | |||
There was a problem hiding this comment.
maybe this comment could use a bit more context
pawelszczerbuk
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change puts
tt.dotin a predicatedscf.ifbased on pipeline peeled iteration.The result is that the final stage is conditional and the peeling
selectis optimized away in the backend.