[tools/triton-tensor-layout] Allow parsing ttgir files with triton_nvidia_gpu ops #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasRaoux
reviewed
Sep 10, 2024
bin/triton-tensor-layout.cpp
Outdated
| @@ -180,6 +181,7 @@ int main(int argc, char **argv) { | |||
| DialectRegistry registry; | |||
| // Register all dialects that can print tensor layout. | |||
| registry.insert<triton::gpu::TritonGPUDialect>(); | |||
| registry.insert<triton::nvidia_gpu::TritonNvidiaGPUDialect>(); | |||
There was a problem hiding this comment.
should we call registerTritonDialects so that we covert any kind of ops?
There was a problem hiding this comment.
That seems totally reasonable, yes!
There was a problem hiding this comment.
are planning to update the PR or do you prefer landing it that way and someone can generalize it later?
There was a problem hiding this comment.
Yes, planning to update -- will do it this afternoon!
ThomasRaoux
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to dump layouts read from an MLIR file, and that file contains ops like
triton_nvidia_gpu.warp_group_dot, this tool needs to know about thetriton_nvidia_gpudialect, or else it will throw an error about not finding the dialect