[TMA] Increment refcount for Py_None in TMA descriptor runtime helpers #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Increment refcount for Py_None in TMA descriptor runtime helpers to avoid deallocating the None object. This fixes a runtime failure like Fatal Python error: none_dealloc: deallocating None
ThomasRaoux
approved these changes
Sep 9, 2024
|
If we return a |
|
BTW, @htyu I just discussed with Thomas, there seem to be other places we didn't increment |
Sure, let me do that. |
|
Landing it now as the mi300 test failure seem an infra issue. |
peterbell10
reviewed
Sep 11, 2024
| @@ -274,6 +274,7 @@ static PyObject *setPrintfFifoSize(PyObject *self, PyObject *args) { | |||
| } | |||
|
|
|||
| Py_END_ALLOW_THREADS; | |||
| Py_INCREF(Py_None); | |||
| return Py_None; | |||
There was a problem hiding this comment.
For future reference there is a Py_RETURN_NONE macro which does this in one line. And yes we should always increment the refcount even for constants like Py_None or Py_False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incrementing refcount for Py_None in TMA descriptor runtime helpers to avoid deallocating the None object. This fixes a runtime failure like
Fatal Python error: none_dealloc: deallocating None