[AMD] Refactor decompose-unsupported-amd-conversions pass #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #3730 |
binarman
commented
Jul 5, 2024
| @@ -1,8 +1,9 @@ | |||
| // RUN: triton-opt %s --split-input-file --decompose-unsupported-amd-conversions=arch=gfx942 | FileCheck %s | |||
There was a problem hiding this comment.
I wanted to rename this file to test/Conversion/amd/decompose-unsupported-conversions-gfx11.mlir, but git marks it as new file and looses history. So I've left it as-is for now.
binarman
force-pushed
the
refactor_decompose_conversions
branch
2 times, most recently
from
bfaa932
to
b23e154
Compare
binarman
changed the title
antiagainst
requested changes
Jul 30, 2024
test/Conversion/amd/decompose-unsupported-conversions-gfx9.mlir
Outdated
Show resolved
Hide resolved
| // RUN: triton-opt %s --split-input-file --decompose-unsupported-amd-conversions=arch=gfx942 | FileCheck %s | ||
|
|
||
| // CHECK: #[[DST_ENC:.+]] = #triton_gpu.blocked<{{.*}}> | ||
| // CHECK: #[[SRC_ENC:.+]] = #triton_gpu.amd_mfma<{{.*}}> |
There was a problem hiding this comment.
Wanna specify out some different pieces between SRC_ENC and TMP_ENC and change the CHECK here to CHECK-DAG? Right now it relies on solely the ordering to not break..
test/Conversion/amd/decompose-unsupported-conversions-gfx9.mlir
Outdated
Show resolved
Hide resolved
test/Conversion/amd/decompose-unsupported-conversions-gfx9.mlir
Outdated
Show resolved
Hide resolved
third_party/amd/lib/TritonAMDGPUToLLVM/DecomposeUnsupportedConversions.cpp
Outdated
Show resolved
Hide resolved
|
@binarman ping on this. Can you merge in main and address comments? |
|
@antiagainst sure, this will be first thing after I finish with small-m dimension FMA optimization. |
This PR: - Simplifying pass code, reusing common code - Introduces supports 3d tensors in mfma -> dot conversion(supported in common code from item above) - Adds more lit tests for decompose-unsupported-amd-conversions pass
binarman
force-pushed
the
refactor_decompose_conversions
branch
from
b23e154
to
cebb7e9
Compare
antiagainst
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces: