Skip to content

Commit

Permalink
[NFC]Remove dead code in Coalesce pass. (#4687)
Browse files Browse the repository at this point in the history
The core Triton is a small number of people, and we receive many PRs
(thank
you!).  To help us review your code more quickly, **if you are a new
contributor (less than 3 PRs merged) we ask that you complete the
following
tasks and include the filled-out checklist in your PR description.**

Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them.

- [x ] I am not making a trivial change, such as fixing a typo in a
comment.

- [x ] I have written a PR description following these
  [rules](https://cbea.ms/git-commit/#why-not-how).

- [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`.

- Select one of the following.
  - [ ] I have added tests.
    - `/test` for `lit` tests
    - `/unittest` for C++ tests
    - `/python/test` for end-to-end tests
  - [ x] This PR does not need a test because `Minor changes`.

- Select one of the following.
  - [ x] I have not added any `lit` tests.
- [ ] The `lit` tests I have added follow these [best
practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices),
including the "tests should be minimal" section. (Usually running Python
code
    and using the instructions it generates is not minimal.)
  • Loading branch information
linuxlonelyeagle authored Sep 12, 2024
1 parent 4942d71 commit eb58b22
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/Dialect/TritonGPU/Transforms/Coalesce.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ struct CoalescePass : public impl::TritonGPUCoalesceBase<CoalescePass> {
// in the memory write at the warp level, resulting in worse performance.
// For loads, we can expect that the gaps won't matter due to the L1
// cache.
unsigned elemNumBits = getElementBitWidth(refTensorType);
perThread = std::min<int>(
perThread, getNumElementsPerThread(op, order, axisInfoAnalysis));
}
Expand Down

0 comments on commit eb58b22

Please sign in to comment.