Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for running vLLM backend #8
Add instructions for running vLLM backend #8
Changes from all commits
1688a33
0ba6200
a4921c1
92124bf
aa8a105
ed108d0
c5213f6
2c6881c
ac33407
d2fdb3f
02c1167
d164dab
5ed4d0e
0cd3d91
45a531f
1e27105
97417c5
d943de2
99943cc
b08f426
682ad0c
e7578f1
502f4db
ea35a73
fe06416
0144d33
0f0f968
b81574d
faa29a6
4259a7e
76c2d89
31f1733
76d0652
a50ae8d
edaff54
33dbaed
6575197
9effb18
8dc3f51
bf0d905
7ec9b5f
3b64abc
3a3b326
48e08e7
9b4a193
45be0f6
204ce5a
8c9c4e7
3ab4774
757e2b2
aa9ec65
e0161f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to hyperlink "python-based backend" to the docs on it when triton-inference-server/backend#88 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should normalize our terms:
python-based or python based
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be towards the first, because I think that'd be clearer and more grammatically correct.
Sources: grammar website about -based words. APA more general rules around hyphenating (principles 1 and 3 seem to apply).
CC: @oandreeva-nv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, Python should be capitalized in my opinion. We capitalize Python in the Python backend README. Capitalizing the "p" in Python also aligns with the capitalization guidelines in Python's style guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a search through the Triton Inference Server GitHub organization for markdown files with the word "Python" in them, we are pretty consistent with using capitalization. There are a few documents in the tutorials where we use both versions that we could update for consistency, e.g. part 6 in tutorials and the new request cancellation document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python-based backend
it isThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an action item here, but a random food for thought that could be nice for both users and developers. If we standardize on a certain python-based-backend git repository structure, we can do something like:
wget
is nice, but won't scale past a single file. Ex: Imaginemodel.py
implementsTritonPythonModel
but importsimplementation.py
that has all the gorey details for certain features.Just some random Tuesday ideas in my head. Core would just be updated to also look for
src/model.py
or whatever standard we set instead of justmodel.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will not work with git clone, since required
model.py
is in sub-directory ofvllm_backend
, plusclone
will clone tests as well.We can discuss the best solution at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the ease of development, I think your earlier idea of symlinks makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it won't work as-is and would require minor changes. Not necessarily asking for this feature at this time, just food for thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a separate goal of improving python backend developer experience (more for things like debugging, ipdb, etc) somewhere in the pipeline, so this came to mind as a tangential idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, by any chance, do you know in what ticket this is tracked? If you don't remember, then no worries