Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate AsyncLLMEngine task gracefully #10

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Terminate AsyncLLMEngine task gracefully #10

merged 1 commit into from
Oct 12, 2023

Conversation

pskiran1
Copy link
Member

@pskiran1 pskiran1 commented Oct 11, 2023 •
edited
Loading

Cleanup the following task running forever.

task: <Task pending name='Task-3' coro=<AsyncLLMEngine.run_engine_loop() running at /usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py:350> wait_for=<Future pending cb=[Task.task_wakeup()]>

@pskiran1 pskiran1 marked this pull request as ready for review October 11, 2023 10:30
@tanmayv25
Copy link
Contributor

Great fix!

@pskiran1 pskiran1 merged commit ab5a811 into main Oct 12, 2023
3 checks passed
@pskiran1 pskiran1 deleted the spolisetty_fix_5566 branch October 12, 2023 05:52
jbkyang-nvi pushed a commit that referenced this pull request Oct 13, 2023
@pskiran1 @jbkyang-nvi
Terminate AsyncLLMEngine task gracefully (#10)
ffbf173
@jbkyang-nvi jbkyang-nvi mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyastremsky dyastremsky dyastremsky approved these changes

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@oandreeva-nv oandreeva-nv Awaiting requested review from oandreeva-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pskiran1 @tanmayv25 @dyastremsky