[draft] feat: Add KV aware routing operator. Update llm example for KV aware example #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
changed the title
rmccorm4
reviewed
Feb 8, 2025
Comment on lines
+146
to
+158
| # [FIXME] build Rust library and bindings once the code is ready, | ||
| # for now, the pre-built artifacts are used | ||
| # cargo build --release | ||
| # RUN git clone --single-branch --branch gluo/pyrouter ${GITLAB_DIR} nova-distributed | ||
| # RUN pip install maturin[patchelf] | ||
| # RUN cd nova-distributed/python-wheels/nova-distributed && maturin build | ||
| # KV publisher C library | ||
| # RUN cd nova-distributed/rust/libnova_llm/ && cargo build --release | ||
| RUN pip install /workspace/triton-distributed/binding_package/wheels/nova_distributed*.whl | ||
|
|
||
| # 'etcd' is runtime dependency | ||
| RUN wget https://github.com/etcd-io/etcd/releases/download/v3.5.18/etcd-v3.5.18-linux-amd64.tar.gz && tar -xzf etcd-v3.5.18-linux-amd64.tar.gz | ||
| RUN cp ./etcd-v3.5.18-linux-amd64/etcd* /usr/local/bin/. |
There was a problem hiding this comment.
FYI these PRs add python-binded rust wheel install into container:
rmccorm4
reviewed
Feb 8, 2025
Comment on lines
+137
to
+144
| # [FIXME] change naming to 'triton-distributed' | ||
| # Install Rust and build nova-distributed wheel | ||
| RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y | ||
| RUN . "$HOME/.cargo/env" | ||
|
|
||
| # Rust 'triton-distributed' library dependency | ||
| # [WIP] 'protobuf-compiler' safe? We already have a version of it somewhere | ||
| RUN apt-get update && apt-get install -y libssl-dev pkg-config libhwloc-dev hwloc libudev-dev clang libclang-dev protobuf-compiler |
There was a problem hiding this comment.
FYI this cargo setup in container is already in latest main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)