Skip to content

test: Add config parameter "execution_context_allocation_strategy" to TensorRT backend #8150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 18, 2025
Merged

test: Add config parameter "execution_context_allocation_strategy" to TensorRT backend #8150

merged 9 commits into from
Apr 18, 2025

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Apr 16, 2025 •
edited by rmccorm4
Loading

What does the PR do?

Add unittests to validate server behavior with various allocation_strategy parameter values.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

Where should the reviewer start?

Test plan:

All TensorRT related tests
L0_model_config--base

  • CI Pipeline ID:
    27050513

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Apr 16, 2025
@yinggeh yinggeh self-assigned this Apr 16, 2025
@yinggeh yinggeh mentioned this pull request Apr 16, 2025
Closed
11 tasks
@yinggeh yinggeh requested a review from rmccorm4 April 16, 2025 18:00
@rmccorm4 rmccorm4 requested a review from tanmayv25 April 16, 2025 20:43
rmccorm4
rmccorm4 reviewed Apr 18, 2025
View reviewed changes
...0_model_config/custom_parameters/tensorrt/invalid/allocation_strategy_invalid_value/expected Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related thread on this testing: triton-inference-server/tensorrt_backend#109 (comment)

Feature PR corresponding to these tests: triton-inference-server/tensorrt_backend#108

rmccorm4
rmccorm4 reviewed Apr 18, 2025
View reviewed changes
@yinggeh yinggeh requested a review from rmccorm4 April 18, 2025 22:42
rmccorm4
rmccorm4 reviewed Apr 18, 2025
View reviewed changes
@yinggeh yinggeh requested a review from rmccorm4 April 18, 2025 23:00
@yinggeh yinggeh changed the title test: Parameterize TensorRT allocation strategy test: Add config parameter "execution_context_allocation_strategy" to TensorRT backend Apr 18, 2025
@yinggeh yinggeh merged commit 901b0e9 into main Apr 18, 2025
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-8281-allocation-strategy-parameter branch April 18, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

Assignees

@yinggeh yinggeh

Labels
PR: test Adding missing tests or correcting existing test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinggeh @rmccorm4