Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add histogram metric type #374

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Aug 7, 2024

What does the PR do?

Support histogram metric type and its functions.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • feat

Related PRs:

triton-inference-server/vllm_backend#56
triton-inference-server/core#386
triton-inference-server/server#7525

Where should the reviewer start?

n/a

Test plan:

n/a

  • CI Pipeline ID:
    17487728

Caveats:

n/a

Background

Customer requested histogram metrics from vLLM.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@oandreeva-nv
Copy link
Contributor

I think we need general tests for this on python backend as well

@krishung5
Copy link
Contributor

+1 on the test. Also I think would be great if we can add the documentation for the new type of metrics: https://github.com/triton-inference-server/python_backend/tree/main/examples/custom_metrics

@yinggeh yinggeh changed the base branch from main to yinggeh-DLIS-7061-add-vllm-metrics August 8, 2024 00:28
@yinggeh yinggeh requested a review from Tabrizian August 13, 2024 20:04
@yinggeh
Copy link
Contributor Author

yinggeh commented Aug 16, 2024

+1 on the test. Also I think would be great if we can add the documentation for the new type of metrics: https://github.com/triton-inference-server/python_backend/tree/main/examples/custom_metrics

Updated. See commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

6 participants