Skip to content

refactor: return error if tensorflow related configs are found by AutoCompleteBackendFields #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ziqif-nv
Copy link

@ziqif-nv ziqif-nv commented Apr 1, 2025

What does the PR do?

Since 25.03, TensorFlow backend is no longer supported by Triton. So if TF related configs are detected by AutoCompleteBackendFields, it should throw error.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

WIP

  • CI Pipeline ID:

Caveats:

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@ziqif-nv ziqif-nv added the PR: refactor A code change that neither fixes a bug nor adds a feature label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: refactor A code change that neither fixes a bug nor adds a feature
Development

Successfully merging this pull request may close these issues.

1 participant