Bump min cxx standard to 17 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we hold off merging this until we have compiled PA against C++17? Should only be a sanity check but I wanna be sure. |
|
@debermudez Sure. Let me know when we can merge this, I'll move it to draft for now. |
debermudez
approved these changes
Jan 5, 2024
oandreeva-nv
force-pushed
the
oandreeva_upgrade_cxx_standard_17
branch
from
f399963
to
feb7c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of the series PRs to update Triton to C++17 standard.
This PR sets Triton's min CXX standard to 17 and uses
TRITON_MIN_CXX_STANDARDeither newly set or from cmake cache