Close client in order to prevent file handle leak #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for contributing/fixing the bug! @michaelwechner can you sign the CLA and resolve the conflict? |
|
Thanks, sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was running the Java triton client without closing, then after approximately 300 requests I got a "too many open files" exception. Closing the client using client.close() prevents this problem.
In the example https://github.com/michaelwechner/close-triton-client/blob/main/src/java/src/main/java/triton/client/examples/SimpleInferPerf.java I did not close the client, whereas you might want to do this as well to make sure people know that they should close the client