Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra support for Scala IDE #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

maris123
Copy link

@maris123 maris123 commented May 9, 2018

No description provided.

else
Paths.get(rootProjectDir, hydraStoreUserSetting).toString()

val sourcepath = allSourceFiles.mkString(",")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source path should contain just the root directories for sources, but allSourceFiles gives you all source files in the project. You can use sourceFolders (for an example, the "presentation compiler" that the IDE is based on also uses -sourcepath, and the setting is initialized inside def initializeCompilerSettings).

@@ -0,0 +1,402 @@
package sbt.internal.inc.hydra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment saying where this file was copied from and the version or git hash (in case we need to update it later).

@@ -0,0 +1,137 @@
package sbt.internal.inc.hydra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment saying where this file was copied from and the version or git hash (in case we need to update it later).

@@ -0,0 +1,398 @@
package sbt.internal.inc.hydra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment saying where this file was copied from and the version or git hash (in case we need to update it later).

in.scalacOptions, in.javacOptions, o2jo(previousAnalysis), o2jo(previousSetup), lookup, sbtReporter, in.order,
skip = false, in.progress, in.incOptions, extra = Array(), log))

if (!in.scalaInstallation.isHydraInstallation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work for me. I tried setting the Project-level Scala installation, but it always returns "false" (not a Hydra installation). It seems that during serialization something happens, in the debugger the installation is an instance of LabelledScalaInstallationReplace

@dragos
Copy link
Member

dragos commented May 16, 2018

I keep getting this in the log:

2018-05-16 11:44:09,830 ERROR [Worker-19] - EclipseSbtBuildManager - bad option: '-cpus'
2018-05-16 11:44:26,179 ERROR [Worker-6] - EclipseSbtBuildManager - bad option: '-cpus'
2018-05-16 11:44:33,513 ERROR [Worker-7] - EclipseSbtBuildManager - bad option: '-cpus'
2018-05-16 11:45:48,349 ERROR [Worker-7] - EclipseSbtBuildManager - bad option: '-cpus'
2018-05-16 11:46:58,068 ERROR [Worker-13] - EclipseSbtBuildManager - bad option: '-cpus'

I deleted the files under ~./.scalaide/compiler-bridges, I saw the IDE building the compiler interface, but it seems to be something wrong in the way it builds it.

We need to make sure:

  • the bad option: -cpus was never shown to me. We need to make sure this error appears in the Errors panel, or else everything looks "fine", but the classfiles are not generated
  • if the Hydra installation directory doesn't have everything we expect (mostly, hydra-bridge) we should issue an error dialog when adding the installation.
  • we need to see why this doesn't work for me... try to delete the bridges and see if it works for you
  • I will attach the distro I use for testing, perhaps some names are not properly matched by regex-es

@maris123
Copy link
Author

It doesn't work using your distro. This happens because the Hydra Bridge jar should be the hydra-bridge_1_0 and should also contain the group id into its name. Also the license-checking jar is missing from the distro.

@dragos dragos mentioned this pull request Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants